QuickReferences 1.2

You are viewing page #5

Show original post

I don't usually provide support for third party plugins. If you want you can alter that plugin as follows. Find in inc/plugins/MinimalEditor/hooks_frontend.php:

$output = $parser->parse_message($mybb->get_input('message'), $parser_options); 

Add after:

$output = quickreferences_fill_placeholders($output); 

This should suffice.

I see, yes, it should work. Ideally this could be handled from within QuickReferences but I could push a PR for your consideration at a later time.

Thanks.

I agree that QuickReferences should handle all cases. Problem is, if I put the placeholders filler within the parser itself there will be a spike in resource usage, because in some places (like showthread for example) it is called several times.

I need to have a look at another way to handle it.

I was thinking of something around the following lines:

$plugins->add_hook('parse_message_end', 'quickreferences_parse_message_end');
function quickreferences_parse_message_end(&$message)
{
    global $mybb, $plugins;

    if(defined('THIS_SCRIPT') && THIS_SCRIPT == 'xmlhttp.php' && $mybb->get_input('action') == 'get_preview')
    {
        $message = quickreferences_fill_placeholders($message);
    }

    $plugins->remove('parse_message_end', 'quickreferences_parse_message_end');
} 

Edit: But indeed, this would be to "provide support for third party plugins", which you would like to avoid.

Hello there,

Is there any way to make all references permanent links. For instance, when I upgrade MyBB and I have to disable to QuickRef plug in, all QuickRef links only show the threadID. I would prefer to have an option to make some QuickREf threadID permanent links without the threadID. Hopefully, I'm elaborating my question well.

No, there is not. QuickReferences is designed to follow through link and title changes, and the only way to do that is to reference to thread identifiers.

Is possible to somehow (no option in ACP is needed, hardcoded is fine) to enable searching threads only from selected forums? Thank you @Shade

EDIT: Nevermind, here is the solution:

line 178
$query = $db->query("
SELECT t.subject, t.tid, f.name AS forumname, u.avatar
FROM ".TABLE_PREFIX."threads t
LEFT JOIN ".TABLE_PREFIX."forums f ON f.fid = t.fid
LEFT JOIN ".TABLE_PREFIX."users u ON u.uid = t.uid
WHERE t.subject LIKE '%" . $db->escape_string($mybb->input['query']) . "%' AND t.closed NOT LIKE 'moved|%' AND t.fid in (10, 11, 99, 101) AND {$unapproved_where} {$permsql}
ORDER BY t.sticky DESC, t.lastpost
LIMIT 10
");

where t.fid are IDs of your forums

It's cleaner if you add your where statement to the $permsql array.

Would you share your idea on example?